search

grafana / grafonnet

Jsonnet library for generating Grafana dashboards.
https://grafana.github.io/grafonnet/
Apache License 2.0
320 stars 18 forks source link

Expanding Query Types for creating "Query Result" dashboard variables #190

Closed srikotu closed 1 month ago

srikotu commented 3 months ago

Overview

This PR expands the queryTypes to create "QueryResult" template variable in Grafana.

Changes

Querytype array has been extended to include QueryResult function.

Impact This change will help users to use set dashboard variables of Query Type: Query Result.

Issue: https://github.com/grafana/grafonnet/issues/191 Please review the changes and merge them if everything is in order.

srikotu commented 3 months ago

@Duologic @malcolmholmes requesting a review of this PR

srikotu commented 2 months ago

@Duologic @malcolmholmes requesting a review of this PR

bump quick set of 👀 please

srikotu commented 1 month ago

@Duologic, thank you very much for the review, accepted your suggestion 👍🏼

Tried to run make -B generate 10.4.1 but it seems like the jsonnet commands in scripts/generate.sh are using older options like -c.

Is grafonnet locked down to use an older jsonnet version 🤔 , couldn't find a version reference in the repo.

Duologic commented 1 month ago

It is using the go-version of jsonnet, I think -c is not supported on the C-version.

Duologic commented 1 month ago

superseded by #206

srikotu commented 1 month ago

It is using the go-version of jsonnet, I think -c is not supported on the C-version.

so should the contributing docs be updated accordingly or the Makefile be updated for the docs to be "correct" 🤔