grafana / helm-charts

Apache License 2.0
1.63k stars 2.26k forks source link

[loki-distributed] `loki.annotations` in values.yaml doesn't apply annotations to all components #1905

Open cwyl02 opened 2 years ago

cwyl02 commented 2 years ago

In https://github.com/grafana/helm-charts/blob/main/charts/loki-distributed/values.yaml#L24-L28 it says loki.annotations applies to all deployments, statefulsets etc but at least the ingester statefulset and distributor deployment are not picking up the k8s pod controller level annotations

PatrickLaabs commented 1 year ago

Hi, since the PR #1906 has been merged: May this issue be closed?

Best Patrick