grafana / helm-charts

Apache License 2.0
1.63k stars 2.26k forks source link

[tempo-distributed] metricsGenerator in helm doesn't populate required configuration in tempo configmap #1987

Open raghuafero opened 1 year ago

raghuafero commented 1 year ago

Problem Statement: Trying to enable metrics generator in tempo for grafana APM feature ( using tempo-distributed helm chart"

What has been tried: metricsGenerator: enabled: true config: storage: path: /var/tempo/generator_wal remote_write:

Actual Result: only "metrics_generator_enabled: true" is seen in the tempo-distributed configmap

YayBurritos commented 1 year ago

I think this has improved in terms of the resulting tempo-distributed-config configmap, but in my very recent experience, the following is also missing even if you do enable the metrics generator:

    overrides:
      metrics_generator_processors:
      - service-graphs
      - span-metrics

Once you have that in place, I think you'll likely see the metrics being generated as expected. I've been chatting with @joe-elliott about this and seems like a good candidate for a PR. Just working through some of the details with him as this would be my first contribution to this repo.

kuzaxak commented 1 year ago

I think it was done after a fix of issue