search

grafana / helm-charts

Apache License 2.0
1.6k stars 2.24k forks source link

[loki-distributed] Incorrect Parameter Configuration #2463

Open stringang opened 1 year ago

stringang commented 1 year ago

When installing loki-distributed using Helm, the default value for the schemaConfig.configs[0].from parameter does not use double quotes for the date format, which causes an installation error.

error info:

failed parsing config: /etc/loki/config/config.yaml: parsing time "2020-09-07T00:00:00.000Z": extra text: "T00:00:00.000Z". Use `-config.expand-env=true` flag if you want to expand environment variables in your config file

source code:

https://github.com/grafana/helm-charts/blob/061c43b7e297e496d5e36cb185b44add8ad952ae/charts/loki-distributed/values.yaml#L213-L216

stieler-it commented 3 months ago

The PR seemed to fix this, but the docs at https://grafana.com/docs/loki/latest/setup/install/helm/install-monolithic/ still show the value without quotes.