grafana / helm-charts

Apache License 2.0
1.62k stars 2.24k forks source link

[tempo-distributed] Container is missing readiness or liveness probe #2966

Open alita1991 opened 7 months ago

alita1991 commented 7 months ago

The Tempo service is currently lacking proper probes, leading to potential issues with monitoring, health checks, and graceful handling of service disruptions. Probes play a critical role in ensuring the stability and reliability of services within our Kubernetes cluster.

This issue was discovered while scanning the helm chart via kube-score: https://github.com/zegl/kube-score/blob/master/README_PROBES.md

The components with missing readiness probes are:

The components with missing liveness probes are:

Is there any reason for not having probes for the given components? If not, what would be the recommendation?

hkailantzis commented 3 months ago

@alita1991 thanks for opening this. Is this something that could be also done for the monolithic version (https://github.com/grafana/helm-charts/tree/main/charts/tempo) ? Or make sense to open another issue for this? Thanks in advance!

Mistral-valaise commented 3 months ago

Hi,

I'm experiencing the same issue with the Grafana Tempo Helm chart (https://github.com/grafana/helm-charts/tree/main/charts/tempo). I've also created an issue to address this problem. https://github.com/grafana/helm-charts/issues/3185