[tempo] bug: Service name is different from the Service name specified in StatefulSets - Githubissues

grafana / helm-charts

Apache License 2.0

1.63k stars 2.26k forks source link

[tempo] bug: Service name is different from the Service name specified in StatefulSets #3042

Open tozastation opened 6 months ago

tozastation commented 6 months ago

Problem Detail:

StatefulSets resource defines serviceName as ${SERVICE_NAME}-headless
However service name is defined in ${SERVICE_NAME}.
So, name resolution with FQDN in Headless Service is not possible.

Resolution:

Assign a headless suffix to the Service resource name
or
Remove Headless prefix from Service Name in StatefulSet

Reference:

StatefulSet (spec.serviceName)
- https://github.com/grafana/helm-charts/blob/main/charts/tempo/templates/statefulset.yaml#L20
Service (metadata.name)
- https://github.com/grafana/helm-charts/blob/main/charts/tempo/templates/service.yaml#L4

dastrobu commented 6 months ago

I think there might be more to this:

https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/:

StatefulSets currently require a Headless Service to be responsible for the network identity of the Pods. You are responsible for creating this Service.

The helm chart is currently not defining a headless service.