grafana / helm-charts

Apache License 2.0
1.67k stars 2.28k forks source link

Add possibility do add common labels in helm chart #3319

Closed Rohlik closed 3 weeks ago

Rohlik commented 2 months ago

Is your feature request related to a problem? Please describe. There is no way how to easily set common labels across all Helm chart Tempo created resources, like (deployments, statefulsets, ingresses, services, servicemonitors, persistent volumes, etc). This leads to difficulties when you have common rules/alerts, for example, "almost full persistent volume" and you want to route them to the responsible owner based on the team label. This is now impossible as the PV/PVC doesn't have related labels 😢.

Describe the solution you'd like In values.yaml, we should be able to specify something like this:

commonLabels:
  foo: bar
  label2: value2

and all resources created by the Tempo chart will have those labels.

Describe alternatives you've considered

Additional context Sadly, the other components from Grafana are missing this support also 😣; see tickets below. It would be nice to have the same method for setting these common labels across charts.

joe-elliott commented 2 months ago

I am fully in support of this. Moving this to the helm charts repo for visibility.

We would gladly take a PR to add this feature.

ftrigari commented 1 month ago

I edited 3 Tempo Charts using the same logic used for Mimir chart.

I didn't edit dependency charts; I'm waiting for a feedback on how to proceed https://github.com/grafana/mimir/issues/9067#issuecomment-2439073840