grafana / helm-charts

Apache License 2.0
1.66k stars 2.28k forks source link

[tempo-distributed] Add metrics max duration config #3321

Closed bvillanueva-mdsol closed 3 weeks ago

bvillanueva-mdsol commented 1 month ago

Background: We wanted to expand current metrics generator's config metrics.max_duration from default 3h to something bigger.

Goal: Allow update on metrics generator's config metrics.max_duration configuration.

Doc: metrics.max_duration is found in this documentation: https://grafana.com/docs/tempo/latest/configuration/#query-frontend

abenbachir commented 1 month ago

When this max_duration config can be merged ?

bvillanueva-mdsol commented 1 month ago

Thanks for the ping @abenbachir. The PR was not updated to latest main. Just updated now. We can now able to merge 🙇

abenbachir commented 1 month ago

@Sheikh-Abubaker this PR needs to be reviewed.

bvillanueva-mdsol commented 1 month ago

Looks like as a workaround I saw this post in community slack channel: https://grafana.slack.com/archives/C01D981PEE5/p1728294653138369?thread_ts=1728293373.828449&cid=C01D981PEE5

        tempo:
          structuredConfig:
            query_frontend:
              metrics:
                max_duration: 12h      

it works on my local too.

@abenbachir , looks like we dont need this PR anymore. What do you think?

abenbachir commented 1 month ago

Looks like as a workaround I saw this post in community slack channel: https://grafana.slack.com/archives/C01D981PEE5/p1728294653138369?thread_ts=1728293373.828449&cid=C01D981PEE5

        tempo:
          structuredConfig:
            query_frontend:
              metrics:
                max_duration: 12h      

it works on my local too.

@abenbachir , looks like we dont need this PR anymore. What do you think?

yeah i saw that thread as well.

Sheikh-Abubaker commented 1 month ago

@bvillanueva-mdsol could you please bump the chart version to 1.19.0 ? Thanks!

bvillanueva-mdsol commented 3 weeks ago

@Sheikh-Abubaker sorry for the late reply. Got it bumped to 1.20.0 on latest updates

Sheikh-Abubaker commented 3 weeks ago

@Sheikh-Abubaker sorry for the late reply. Got it bumped to 1.20.0 on latest updates

@bvillanueva-mdsol no worries!

Sheikh-Abubaker commented 3 weeks ago

@mapno could you please review this.