search

grafana / helm-charts

Apache License 2.0
1.61k stars 2.24k forks source link

tempo-distributed traceql queryFrontend missing traceql metrics configuration options #3323

Open ovidiubuligan opened 6 days ago

ovidiubuligan commented 6 days ago

The following is the templating composition of config.yaml for the whole tempo-distributed from the values file :

  query_frontend:
    max_outstanding_per_tenant: {{ .Values.queryFrontend.config.max_outstanding_per_tenant }}
    max_retries: {{ .Values.queryFrontend.config.max_retries }}
    search:
      target_bytes_per_job: {{ .Values.queryFrontend.config.search.target_bytes_per_job }}
      concurrent_jobs: {{ .Values.queryFrontend.config.search.concurrent_jobs }}
    trace_by_id:
      query_shards: {{ .Values.queryFrontend.config.trace_by_id.query_shards }}

The traceql metrics options can be seen here : https://grafana.com/docs/tempo/latest/operations/traceql-metrics/#set-traceql-metrics-query-options Setting traceql query options is not possible . Can the helm template be future ready with by modifying the above templated config with something like the pseudo helm :

  # values file
  queryFrontend:
    extraConfig : 
         metrics:
             concurrent_jobs: 42

  query_frontend:
    max_outstanding_per_tenant: {{ .Values.queryFrontend.config.max_outstanding_per_tenant }}
    max_retries: {{ .Values.queryFrontend.config.max_retries }}
    search:
      target_bytes_per_job: {{ .Values.queryFrontend.config.search.target_bytes_per_job }}
      concurrent_jobs: {{ .Values.queryFrontend.config.search.concurrent_jobs }}
    trace_by_id:
      query_shards: {{ .Values.queryFrontend.config.trace_by_id.query_shards }}
    {{ .Values.queryFrontend.extraConfig }}