grafana / helm-charts

Apache License 2.0
1.67k stars 2.28k forks source link

[tempo-operator]: Adds first implementation of tempo-operator helm-chart #3329

Open suyash-811 opened 2 months ago

suyash-811 commented 2 months ago

Background: We were expressing interest in #3032 to create a helm-chart for tempo-operator. I started working on this a while ago, and i have an initial working version of the helm-chart.

I would however like to also get some help on certain open questions, which could help maintaining this chart easier in the future. (Questions listed below)

  1. How should we deal with CRDs? I have included them in the crds folder in the chart. However, often migrating to newer versions of the CRDs could be challenging. Any ideas on how to handle CRDs?
  2. This one would be for someone from the tempo-operator community (I'll link them in the PR later). The deployment contains some environment variables which specify image versions for several services(code block below). Do removing any of these ENV VARs cause the operator to behave differently?
          env:
          - name: RELATED_IMAGE_TEMPO
            value: docker.io/grafana/tempo:2.5.0
          - name: RELATED_IMAGE_TEMPO_QUERY
            value: docker.io/grafana/tempo-query:2.5.0
          - name: RELATED_IMAGE_TEMPO_GATEWAY
            value: quay.io/observatorium/api:main-2024-05-29-ca8d2de
          - name: RELATED_IMAGE_TEMPO_GATEWAY_OPA
            value: quay.io/observatorium/opa-openshift:main-2024-04-29-914c13f
          - name: RELATED_IMAGE_OAUTH_PROXY
            value: quay.io/openshift/origin-oauth-proxy:4.12

Looking forward to suggestions for improvements and collaborating on bringing this to release soon! 😄

(P.S. apologies if i missed out any details. This is my first PR here.)

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

suyash-811 commented 2 months ago

I pushed a commit to fix problems with linting, but pushed without the signoff. Thus, had to rebase with a signoff again.