grafana / helm-charts

Apache License 2.0
1.67k stars 2.28k forks source link

[tempo] Add ability to set `persistentVolumeClaimRetentionPolicy` in Tempo StatefulSet #3353

Closed aerfio closed 2 weeks ago

aerfio commented 1 month ago

Add ability to set persistentVolumeClaimRetentionPolicy like in other charts:

I can also expose the ability to override

    whenDeleted: Delete
    whenScaled: Delete

if requested.

aerfio commented 1 month ago

Hi @Sheikh-Abubaker, I see that you're reviewing other PRs, could you please take a look at this one? Thank you in advance 😄

Sheikh-Abubaker commented 1 month ago

Hi @Sheikh-Abubaker, I see that you're reviewing other PRs, could you please take a look at this one? Thank you in advance 😄

Hey @aerfio sorry for the delay, I'm a bit occupied as of now, but will review it soon!

Sheikh-Abubaker commented 2 weeks ago

Hey @aerfio you'd need to bump chart version to 1.14.0 before I could approve this!

aerfio commented 2 weeks ago

@Sheikh-Abubaker done!

Sheikh-Abubaker commented 2 weeks ago

@aerfio could you please address the failed CI check by running helm-docs inside /charts/tempo/

aerfio commented 2 weeks ago

@Sheikh-Abubaker re-run helm-docs.