grafana / helm-charts

Apache License 2.0
1.67k stars 2.28k forks source link

Breaking: TempoQuery Startup #3417

Open trevatk opened 2 weeks ago

trevatk commented 2 weeks ago

TempoQuery is failing to start when enabled in helm chart with most recent version 1.13.0. Never looked at the source code for tempoQuery not sure if an argument would fix? But figured without supporting documentation it should not be released?

helm install tempo-grafana grafana/tempo --version 1.12.0 flag seems to work for now.

flag provided but not defined: -query.base-path Usage of /tempo-query: -config string A path to the plugin's configuration file

submitted a PR to revert breaking jump. https://github.com/grafana/helm-charts/pull/3416

paul-at-cybr commented 1 week ago

+1 to this issue, also observing it here (on chart 1.14.0)

jkleinlercher commented 1 day ago

+1 also from my side

may I add some additional infos, which probably helps:

when applying tempo helm chart with values .tempoQuery.enabled=true container tempo-query fails with

flag provided but not defined: -query.base-path
Usage of /tempo-query:
  -config string
        A path to the plugin's configuration file

tempo-query container arg --query.base-path is defined in https://github.com/grafana/helm-charts/blob/c6a19af28c57970c3a9e2e09bc6bfd6ad496f788/charts/tempo/templates/statefulset.yaml#L120

It seems there was a breaking change for tempo-query in this release which is part of this helm chart update: https://github.com/grafana/tempo/releases/tag/v2.6.1

the specific pull request for this breaking change is: https://github.com/grafana/tempo/pull/3840 provided by @frzifus

I think more or less the same changes which were done in the tempo-operator in https://github.com/grafana/tempo-operator/pull/1025 need to get applied to the helm chart?

frzifus commented 23 hours ago

Oh shoot, I was not aware that its directly deployed without the operator. y, we need to do something like that. Deploy Jaeger query next to tempo query. As of 1.58, Jaeger no longer supports the grpc plugin, so we've turned tempo-query into a standalone backend.