search

grafana / helm-charts

Apache License 2.0
1.67k stars 2.28k forks source link

[tempo-distributed] add persistentVolumeClaimRetentionPolicy for ingester #3419

Closed pohldk closed 1 week ago

pohldk commented 1 week ago

This was added to Loki distributed chart but would be useful for tempo distributed chart as well.

CLAassistant commented 1 week ago

CLA assistant check
All committers have signed the CLA.

Sheikh-Abubaker commented 1 week ago

Hey @pohldk, could you please bump the chart version to 1.23.0 in order to fix the CI lint test.

pohldk commented 1 week ago

@Sheikh-Abubaker done 👍

jkroepke commented 1 week ago

Please create a distinct PR for each chart.

The CI and approval process is not designed for PR over multiple charts.

pohldk commented 1 week ago

Please reopen, clearly a mistake @jkroepke we simply need to only run helmdocs on tempo. My bad.

pohldk commented 1 week ago

@jkroepke if you reopen you it should update the PR with the corrected commit on the branch:

https://github.com/grafana/helm-charts/commit/bb63dd6c235a37f0308da6eaa7e1d2ccdf6882cd

jkroepke commented 1 week ago

It seems like you do a force-push with prevents a reopen.

image

Please create a new PR, thanks!

pohldk commented 1 week ago

@jkroepke https://github.com/grafana/helm-charts/pull/3429 done