grafana / helm-charts

Apache License 2.0
1.59k stars 2.24k forks source link

[enterprise-logs] helm chart leave the leftovers after uninstall #854

Open vlad-diachenko opened 2 years ago

vlad-diachenko commented 2 years ago

After:

$helm uninstall -n gel-test enterprise-logs

we can see that tokengen job and secrets are not removed :

$ kubectl get all -n gel-test
NAME                                 READY   STATUS      RESTARTS   AGE
pod/enterprise-logs-tokengen-rpbjz   0/1     Completed   0          113m

NAME                                 COMPLETIONS   DURATION   AGE
job.batch/enterprise-logs-tokengen   1/1           12s        113m
$ kubectl get secrets
NAME                                   TYPE                                  DATA   AGE
default-token-q6b74                    kubernetes.io/service-account-token   3      32h
enterprise-logs-tokengen-token-77jpc   kubernetes.io/service-account-token   3      115m
gel-admin-token                        Opaque                                2      115m
mansoor17syed commented 1 year ago

Hey @vlad-diachenko , I was able to reproduce this issue. I see the job and secret not getting deleted.

mansoora@wsl2-u20.04://home/mansoora/zpe_dep/CSF-CHARTS/cpro (1.0>) $ kubectl get all -n smk8 NAME READY STATUS RESTARTS AGE pod/enterprise-logs-tokengen-vctdg 0/1 Completed 0 2m36s

NAME COMPLETIONS DURATION AGE job.batch/enterprise-logs-tokengen 1/1 15s 2m38s mansoora@wsl2-u20.04://home/mansoora/zpe_dep/CSF-CHARTS/cpro (1.0>) $ kubectl get secrets -n smk8 NAME TYPE DATA AGE gel-admin-token Opaque 2 2m30s mansoora@wsl2-u20.04://home/mansoora/zpe_dep/CSF-CHARTS/cpro (1.0>)

I would like to fix this issue.