search

grafana / incident-community

Public repository for Grafana Incident feedback, bug reports, discussions, and updates.
26 stars 2 forks source link

Links from Slack are malformed #39

Closed dannykopping closed 1 year ago

dannykopping commented 1 year ago

Describe the bug Messages ingested from Slack have the format link|<title>, and when these links are clicked they contain |<title>

To Reproduce Steps to reproduce the behavior:

  1. Go to an incident
  2. Click on a link from a message ingested from Slack
  3. Link does not work because it is malformed

Expected behavior The URL should not be malformed.

Screenshots image The link, when copied, has this format: https://....%7Clink.

Relevant system information

Grafana: v9.4.0-42921pre (d5274dfdda) Incident: v1.0.23

matryer commented 1 year ago

Thanks @dannykopping - we are actively working on solving this.

matryer commented 1 year ago

@dannykopping we have a fix for this going out this week, would you be up for testing this a little for us, and providing some feedback?

dannykopping commented 1 year ago

@matryer certainly, let me know when it's live and i'll create a drill incident

matryer commented 1 year ago

If you could cause an actual incident in your systems instead, that'd be much appreciated. :)

idk-92 commented 1 year ago

Closing this issue as this has been resolved, please let us know if is still a problem and we'll reopen this issue