search

grafana / incident-community

Public repository for Grafana Incident feedback, bug reports, discussions, and updates.
26 stars 2 forks source link

Character in Teams team name breaks integration search function #90

Closed asreich closed 8 months ago

asreich commented 8 months ago

Describe the bug

When trying to configure the MS Teams integration for IRM we noticed that if we spelled out out team name in the search bar "DM&T" it breaks the search panel and causes an error.

To Reproduce Steps to reproduce the behavior:

  1. Install MS Teams integration on IRM Integrations page
  2. Click on "Run when an event fires"
  3. Start searching for a team name with an "&" character in it
  4. See error

Expected behavior

The "&" character, nor any other valid special characters supported in MS Teams team names break this search function.

Screenshots

image

Relevant system information

Grafana Cloud v10.4.0-65875 (b758b91e84) Grafana IRM v1.37.4

twu commented 8 months ago

👋 Thank you for reaching out and reporting the issue! We have a fix ready which should go out with the next release. I will let you know once that is done :)

twu commented 8 months ago

@asreich We just released v1.38.0 which includes a fix for this issue 🤞 Thank you again for reporting and please let us know if this does or doesn't fix the issue 🙇

asreich commented 8 months ago

Confirmed fixed, thank you!