grafana / influxdb-08-datasource

Data source plugin for InfluxDB 0.8.x
Apache License 2.0
6 stars 11 forks source link

Plugin seems broken on grafana-4.0.2 #10

Closed smartattack closed 7 years ago

smartattack commented 7 years ago

Installed Centos RPM: grafana-4.0.2-1481203731.x86_64

I had a few dashboards that were using the Influx-0.8 plugin. They all stopped working upon upgrade. The datasource still passes the validation test, but queries fail.

Message:
Cannot read property '_seriesQuery' of undefined

Stack trace:
TypeError: Cannot read property '_seriesQuery' of undefined
    at eval (http://grafana.xxx:8000/public/plugins/grafana-influxdb-08-datasource/datasource.js?bust=1483589508008:54:18)
    at l (http://grafana.xxx:8000/public/app/boot.85c49108.js:48:28969)
    at Function.Sg [as map] (http://grafana.xxx:8000/public/app/boot.85c49108.js:49:29676)
    at InfluxDatasource.query (http://grafana.xxx:8000/public/plugins/grafana-influxdb-08-datasource/datasource.js?bust=1483589508008:35:22)
    at h.f.issueQueries (http://grafana.xxx:8000/public/app/boot.85c49108.js:42:19495)
    at h.issueQueries (http://grafana.xxx:8000/public/app/boot.85c49108.js:18:27260)
    at g (http://grafana.xxx:8000/public/app/boot.85c49108.js:38:29545)
    at http://grafana.xxx:8000/public/app/boot.85c49108.js:38:29717
    at o.$eval (http://grafana.xxx:8000/public/app/boot.85c49108.js:39:5357)
    at o.$digest (http://grafana.xxx:8000/public/app/boot.85c49108.js:39:3843)
smartattack commented 7 years ago

Disregard - wallrat's PR fixes this issue for me.

findneville commented 7 years ago

Is there a link to this fix that you can share? Have same problem.

smartattack commented 7 years ago

Yes, I pulled in a couple line fix from a pull request that was outstanding at the time. FWIW I believe it was merged before 4.1 because I updated and did not have to re-apply any fix. In the meanwhile I upgraded to Influx 1.1, also, so I'm using the newer influx datasource.

On Wed, Feb 1, 2017 at 2:39 PM, findneville notifications@github.com wrote:

Is there a link to this fix that you can share? Have same problem.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/grafana/influxdb-08-datasource/issues/10#issuecomment-276759140, or mute the thread https://github.com/notifications/unsubscribe-auth/AIdKxWgDwJgrhGxMBGrGsm_F4O82Mz88ks5rYN-DgaJpZM4LbVet .

tinco commented 7 years ago

It's this one: https://github.com/grafana/influxdb-08-datasource/pull/9/commits/d37371fc5868c81d23f0307cbb6f53aaf17a2ce2

The file is located at /var/lib/grafana/plugins

xavi- commented 7 years ago

Any chance d37371f could be merged to master?