search

grafana / influxdb-flux-datasource

Grafana datasource plugin for Flux (InfluxDB)
Apache License 2.0
51 stars 21 forks source link

Include sub-directory when packaging the release ZIP #30

Closed AlexanderWert closed 4 years ago

AlexanderWert commented 5 years ago

When using Grafana's GF_INSTALL_PLUGINS property for installing this datasource when using the grafana docker image (http://docs.grafana.org/installation/docker/), the installation fails.

Example: GF_INSTALL_PLUGINS=https://github.com/grafana/influxdb-flux-datasource/releases/download/5.2.11/influxdb-flux-datasource-5.2.11.zip;Flux

Reason that it fails: The release ZIP-file does not include a sub-directory. So Grafana extracts all the files directly into the "/var/libs/grafana/plugin" directory and, thus, cannot recognize the datasource correctly.

It would be great if all the content within the release ZIP files could be moved to a sub-directory of the zip-file, so this great Grafana installation feature can be used!

Thanks!

briangann commented 4 years ago

that was a change to the new toolkit package, and will be updated to include the path in a future release.

amotl commented 4 years ago

Hi there,

we had the very same issue which has been resolved through https://github.com/panodata/grafana-map-panel/issues/15 and https://github.com/grafana/grafana/issues/20071 ff., thanks to @dprokop and @ryantxu.

We just checked with the current master and can confirm the packaging now includes the subdirectory as intended.

npx grafana-toolkit plugin:ci-build
npx grafana-toolkit plugin:ci-package

So, closing this issue might be appropriate.

With kind regards, Andreas.