search

grafana / intro-to-mltp

Introduction to Metrics, Logs, Traces and Profiles session companion code.
GNU Affero General Public License v3.0
365 stars 80 forks source link

Why multiplying by `55` in Request Rate panel in `MLT dashboard`? #54

Closed gczarnocki closed 11 months ago

gczarnocki commented 1 year ago

Hello. I am wondering why there's a multiplication by 55 in MLT dashboard in Request Rate panel, here:

          "expr": "(sum by (http_target)(rate(traces_spanmetrics_latency_sum{http_target=~\"${httpEndpoint}\",service_version=~\"${serviceVersion}\"}[1m]))) / (sum by (http_target)(rate(traces_spanmetrics_latency_count{http_target=~\"${httpEndpoint}\",service_version=~\"${serviceVersion}\"}[1m]))) * 55",

Thank you for your reply!

hedss commented 11 months ago

Hi @gczarnocki This was actually originally to boost the request numbers up (this repo actually is buried in the roots of my interview all those years ago). I'll raise a PR to drop this, as artificial numbers aren't required anymore esp. now we've included k6.

Also, apologies for the delay in response, first time I've been able to properly come back to the repo in a while!

hedss commented 11 months ago

Changed in #58

hedss commented 11 months ago

Merged and closed.