fix: docker-compose env issue & update readme

grafana / intro-to-mltp

Introduction to Metrics, Logs, Traces and Profiles session companion code.

GNU Affero General Public License v3.0

329 stars 72 forks source link

fix: docker-compose env issue & update readme #70

Closed novalagung closed 7 months ago

novalagung commented 7 months ago

[x] fix: error OTEL_EXPORTER_OTLP_TRACES_INSECURE contains true, which is an invalid type, it should be a string, number, or a null
[x] fix: incorrect MLT dashboard URL

CLAassistant commented 7 months ago

All committers have signed the CLA.

hedss commented 7 months ago

A note about OTEL_EXPORTER_OTLP_TRACES_INSECURE needing to be "true". For style consistency with the rest of the services, yep, it should be quoted, we were inconsistent!

Practically, it absolutely doesn't matter. The variables are unmarshalled as shell variables, not YAML, and the shell will deal with, and pass, the value in exactly the same way. If there was a space in it, that'd get into globbing rules, but we won't go there. :)