search

grafana / intro-to-mltp

Introduction to Metrics, Logs, Traces and Profiles session companion code.
GNU Affero General Public License v3.0
365 stars 80 forks source link

Regex update #95

Closed Elibonadies10 closed 2 months ago

Elibonadies10 commented 5 months ago

Eliminating the forward slash in the regex so the variables correctly populate in the dashboard. Currently there are two sets of endpoints, ones with a "/" and ones without. The ones without also have a label for service version, allowing the dashboards to populate correctly.

CLAassistant commented 5 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

hedss commented 4 months ago

There's actually only one set of nomenclature now, @SeamusGrafana actually PRd a change for this a few months ago: https://github.com/grafana/intro-to-mltp/commit/e9f4d521afef0b388a3d6a6b352d1298456e8cc0

Can you verify that this is definitely not working with the latest built images?

hedss commented 4 months ago

I've just run this and it works exactly as expected: image

Maybe you have old cached containers? I'd recommend a docker compose pull, removing all the current containers (docker rm -f $(docker ps -aq) and then trying again.