search

grafana / iot-sitewise-datasource

IoT Sitewise
Apache License 2.0
19 stars 9 forks source link

Upgrade yaml package #249

Closed fridgepoet closed 8 months ago

fridgepoet commented 8 months ago

What this PR does / why we need it: This PR upgrades cspell, fork-ts-checker-webpack-plugin and add cosmiconfig resolution in order to upgrade the package yaml version. The main reason the older version of yaml was used was due to a transitive dependency of an older version of cosmiconfig.

fork-ts-checker-webpack-plugin and cspell were on older versions requiring an older version of cosmiconfig. fork-ts-checker-webpack-plugin and cspell were updated, but finally @emotion/css still used an older version of cosmiconfig. So the latest version of cosmiconfig was added to resolutions.

Which issue(s) this PR fixes:

Fixes https://github.com/grafana/oss-plugin-partnerships/issues/465

Special notes for your reviewer: Is the following message during yarn install any issue?

Resolving packages...
warning Resolution field "cosmiconfig@8.3.6" is incompatible with requested version "cosmiconfig@^7.0.0"
warning Resolution field "cosmiconfig@8.3.6" is incompatible with requested version "cosmiconfig@8.0.0"

I sanity checked this locally and saw no issues.

Thank you Kevin and Ida for the help!

fridgepoet commented 8 months ago

Sorry apparently a higher version of yaml was needed https://github.com/grafana/iot-sitewise-datasource/pull/253