grafana / iot-sitewise-datasource

IoT Sitewise
Apache License 2.0
19 stars 9 forks source link

Use query region to get client for queries #258

Closed iwysiu closed 7 months ago

iwysiu commented 7 months ago

What this PR does / why we need it: We weren't using the region from the query to get the client, despite sending it. This PR uses the region in the config sent to the SessionCache. I can write a test for if we think we need one, but it honestly seemed a bit silly.

As a side note it feels like we have a lot of unnecessary abstraction in the sitewise plugin.

Which issue(s) this PR fixes:

Fixes #250

Special notes for your reviewer:

sarahzinger commented 7 months ago

Agreed that if we made this mistake once, we can make it again, we shouldn't worry about tests being obvious!