search

grafana / iot-sitewise-datasource

IoT Sitewise
Apache License 2.0
18 stars 9 forks source link

Explore: optimize result aggregation #272

Closed njvrzm closed 6 months ago

njvrzm commented 8 months ago

Aims to speed up result aggregation in the client. Previously this scanned the list of entries to look for a match for each new result; now it will maintain a map of EntryId to index.

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

njvrzm commented 8 months ago

As for benchmarking, I'd love that. I don't have any sense of how much this might affect performance, and it depends entirely on the characteristics of the data: like, (to take it to the extreme case) if every single EntryId happened to be the same, this change would do virtually nothing. Also since the aggregation is happening to data coming in from the network, IO latency might make this insignificant. I think my next step is probably to get the plugin running locally and do some profiling.

njvrzm commented 6 months ago

We can revive this if it comes up but for now I don't think this is worth pursuing.