search

grafana / iot-sitewise-datasource

IoT Sitewise
Apache License 2.0
19 stars 9 forks source link

feat: add list time series to query editor #336

Open ssjagad opened 6 days ago

ssjagad commented 6 days ago

What this PR does / why we need it: This PR adds the implementation for the listTimeSeries API call in the SitwiseSDK. It extends the query editor with a form that allows users to populate the parameters for the API call correctly.

Which issue(s) this PR fixes: Users can now query disassociated data (aka unmodeled data) and filter on assetId or alias prefix for specific data streams.

Fixes #

Special notes for your reviewer:

CLAassistant commented 6 days ago

CLA assistant check
All committers have signed the CLA.

ssjagad commented 2 days ago

Looking good, I think we just need to remove the old form styles.

A question for me though is what do we expect users to do with this data? I notice it is called "time series" but we're rendering it as a table... I guess because it is a list of time series? Would users expect to be able to render this as a time series?

Also as a heads up, I'm made a draft of your pr here #339 just to run the ci (IIRC our e2e tests require the pr be made by a maintainer, will let you know if I see any issues but so far so good)

This API is to retrieve a list of timeSeries data that matches certain filters. It will display the name/alias, id, and some other unique identifying information for a datastream. Customers can use the result of this API to call other API's such as GetAssetPropertyValueHistory and get actual timeSeries data.