grafana / jsonnet-libs

Grafana Labs' Jsonnet libraries
Other
625 stars 160 forks source link

feat: Tomcat log expression update #1301

Closed algchoo closed 2 months ago

algchoo commented 2 months ago

Description

The main purpose of this PR is to update the log expression for Apache Tomcat to accept either the filename or log_type label. The intention is to allow users running tomcat on k8s to not have to input an arbitrary value for filename that may lead to confusion, instead the log_type label has a static value users can just copy/paste.

I noticed that we accidentally created two separate mixins. One called apache-tomcat-mixin and the other named tomcat-mixin. The k8s plugin support changes were actually only applied to tomcat-mixin which is not what the integration points to by default. I've removed the extra mixin and made updates accordingly.

Changes