search

grafana / jsonnet-libs

Grafana Labs' Jsonnet libraries
Other
625 stars 160 forks source link

Consider removing the default `super.withImagePullPolicy('IfNotPresent')` for containers #752

Open giard-alexandre opened 2 years ago

giard-alexandre commented 2 years ago

Since k8s now sets the imagePullPolicy automatically upon creation, setting it to IfNotPresent for the container to be valid is not required anymore. https://github.com/grafana/jsonnet-libs/blob/98c3060877aa178f6bdfc6ac618fbe0043fc3de7/ksonnet-util/grafana.libsonnet#L19

Overriding things like this can be cumbersome with jsonnet so it would be nice to not be forcing this on all containers created using the library. Either removing this default entirely or just making the default pull policy value configurable "globally" would be greatly appreciated.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.