grafana / k6-docs

The k6 documentation website.
https://grafana.com/docs/k6/latest/
87 stars 221 forks source link

Update browser tap to async #1564

Closed inancgumus closed 6 months ago

inancgumus commented 6 months ago

What?

Updates the browser module's Tap methods to async.

We're putting this change into the main-browser-async branch because we're still discussing our options for migrating the K6 browser from sync to async.

Checklist

Related PR(s)/Issue(s)

Updates https://github.com/grafana/xk6-browser/issues/1251

inancgumus commented 6 months ago

@ankur22

I think it's worth also adding the tap docs for the touchscreen class. I've been adding missing docs whenever I've worked on an API that requires them e.g. frame.isVisible.

👍 I thought about this, but to keep the PR focused, I preferred to update only the existing documentation for sync to async for Tap. I've added this as a task in the issue, and we can do it in the next PR.