Update to Async `ElementHandle` - Githubissues

grafana / k6-docs

The k6 documentation website.

https://grafana.com/docs/k6/latest/

87 stars 220 forks source link

Update to Async `ElementHandle` #1598

Closed inancgumus closed 5 months ago

inancgumus commented 5 months ago

What?

Update relevant ElementHandle methods from sync to async.

Checklist

[x] I have used a meaningful title for the PR.
[x] I have described the changes I've made in the "What?" section above.
[x] I have performed a self-review of my changes.
[x] I have run the npm start command locally and verified that the changes look good.

[x] I have made my changes in the docs/sources/next folder of the documentation.
[ ] I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
[ ] I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).

Related PR(s)/Issue(s)

Updates: grafana/xk6-browser#1296

inancgumus commented 5 months ago

@ankur22

Nice work! I may have missed somethings though since there were a lot of changes.

Thanks! I've fixed what you could find here.

I've checked everything from scratch and found another issue: setInputFiles didn't have return header. Fixed c417818.