search

grafana / k6-jslib-aws

Javascript Library allowing to interact with AWS resources from k6 scripts
Apache License 2.0
18 stars 29 forks source link

update terser dependency vulnerability #17

Closed mcnamaram closed 1 year ago

mcnamaram commented 1 year ago
mstoykov commented 1 year ago

Thanks for this PR :bow:

It looks all alright but I don't get why you need to rename the hostname, although it also works. Which is also confusing and I guess this is just me not gettign something that docker does ? :thinking:

mike-mcnamara commented 1 year ago

it was confusing to me too. it is actually a localstack path-style issue where AWS is deprecating path-style and to use virtual hosting in localstack we can't run "localhost:4566" without updating /etc/hosts file. i did some digging and a much shorter path than what I went through is: https://github.com/localstack/localstack/issues/1792 https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html and https://docs.localstack.cloud/aws/s3/ at the bottom. In my testing, i discovered it handles it for all the localstack services so just changing hostname was easier than making some hack to support s3 alone.