grafana / k6-jslib-aws

Javascript Library allowing to interact with AWS resources from k6 scripts
Apache License 2.0
18 stars 29 forks source link

Wip/ssm #18

Closed mcnamaram closed 1 year ago

mcnamaram commented 1 year ago

This is rebased on top of the update terser dependency PR. I was trying to make them separate choices but also wanted the vulnerability update included. i can split them again if you wish.

mstoykov commented 1 year ago

Hi @mcnamaram, thank you for the PR :bow:

@oleiade is currently not available to review this and unfortunately I likely won't have time to look at it in enough detail to be merged. Especially as I am no longer that associated with this project :(

I will try to get #17 merged, I just have a question there.

Also this currently says "wip" but I don't understand what is the work that is in progress. Is there something that isn't finished or did you just not update the name :thinking:

mike-mcnamara commented 1 year ago

ah, i was following the pattern of the other branch names when i saw them earlier. at some point i think i do want to implement the other methods, but nothing is a blocker right now. it all works and i'm using it in my tests.

oleiade commented 1 year ago

Hi @mike-mcnamara

I'm back on board ⛵ and will take a look at your PR in the upcoming days. Thanks for your patience 🙇🏻

mcnamaram commented 1 year ago

ok, awesome, i'll go through this and patch up your suggestions hopefully by this weekend.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.