search

grafana / k6-jslib-aws

Javascript Library allowing to interact with AWS resources from k6 scripts
Apache License 2.0
18 stars 29 forks source link

Add support for SQS #27

Closed nickcaballero closed 1 year ago

nickcaballero commented 1 year ago

This PR adds support for SQS. Part of it involved signing the Host header, which is required by AWS.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

oleiade commented 1 year ago

Looks good @nickcaballero 👍🏻 🙇🏻 Thanks for integrating the requested changes, much appreciated!

Would you say the PR is ready to be merged ❓

nickcaballero commented 1 year ago

Looks good @nickcaballero 👍🏻 🙇🏻 Thanks for integrating the requested changes, much appreciated!

Would you say the PR is ready to be merged ❓

Yeah I think so.

oleiade commented 1 year ago

Hi @nickcaballero, great 🤝

Could you please rebase the current state of the main branch? I'll make sure to merge this as soon as it's done. Please let me know when it is and if I can assist you in any ways 😄

nickcaballero commented 1 year ago

@oleiade Done!

oleiade commented 1 year ago

Perfect, thank you very much 🙇🏻

Merging, and this will go in our next release who doesn't have a set release date at this point, but I'll make sure to notify you here 👏🏻