search

grafana / k6-jslib-aws

Javascript Library allowing to interact with AWS resources from k6 scripts
Apache License 2.0
18 stars 29 forks source link

Honoring scheme and bucket pathing #44

Closed MarkCupitt closed 1 year ago

MarkCupitt commented 1 year ago

https://github.com/grafana/k6-jslib-aws/issues/43

As promised, this is a quick and dirty fix .. to allow the scheme to work, I also fixed the bucket paths, to work with minio, putting them as bucket.url broke dns on everything except aws

Most of the libs I support provide this param which I think supports the bucket pathing I used s3forcepathstyle: true

Have tested this on my local minio server, seems to work fine .. I would be confident you could say taht you supported minio if you wanted to with these fixes

Ill leave you to fix my mess and integrate it nicely, Im totally flat out, sorry

Feel free to ping me with any questions, happy to help out where I can

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.