search

grafana / k6-jslib-aws

Javascript Library allowing to interact with AWS resources from k6 scripts
Apache License 2.0
18 stars 29 forks source link

Kms #6

Closed hagabor closed 2 years ago

hagabor commented 2 years ago

Added KMS Service with GenerateDataKey function only (with parameters only for KeyId and NumberOfBytes).

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

oleiade commented 2 years ago

PR Checklist:

oleiade commented 2 years ago

I've tested the KMS feature you introduced @hagabor and everything seems to work as expected 🎉 Great job 🤝

Please go ahead and integrate the suggested changes, and we should be good to merge this in preparation for a v0.5.0 release. In order to stay productive, if I do not get an answer from you in the upcoming 7 days, I will go ahead and commit my suggestions and merge this so we don't stay blocked.

Cheers!

hagabor commented 2 years ago

Dear Théo,

Sorry to responded with such delay. I'm going to integrate the suggested changes.

brgds, Gábor

hagabor commented 2 years ago

Dear Théo,

I've added some changes. One place I've left comment from the initial SecretsManager service (what I've used as starting point). Also changed export, and import symbols. Now seems working. Please review if I can ask you. Thanks!

Brgds, Gábor

oleiade commented 2 years ago

Hey @hagabor

Thanks a lot for this, much appreciated 🙇🏻 I'll merge this, and add end 2 end tests for it myself 👍🏻