Add ESLint typescript configuration and address warnings in src folder

grafana / k6-jslib-aws

Javascript Library allowing to interact with AWS resources from k6 scripts

Apache License 2.0

18 stars 28 forks source link

Add ESLint typescript configuration and address warnings in src folder #81

Closed oleiade closed 6 months ago

oleiade commented 8 months ago

This Pull Request adds a ESLint configuration to the src folder, specific to typescript, based on @EdvinasDaugirdas 's recommendation to use the eslint-typescript:recommended plugin.

This PR also addresses linter warnings in the src/ folder, and adds a linting Github action.

oleiade commented 7 months ago

It would be great if we could have a shared linter config as a single source of truth and import it here and in the docs. I agree. I'm just not sure how we would set and communicate the source of truth, though 🤔 In a convenient way, I mean.

Also, in some recent discussions, we questioned whether the examples were something we wanted to keep or care about, so I'm not sure this would be the right place, in light of that.