search

grafana / k6-jslib-aws

Javascript Library allowing to interact with AWS resources from k6 scripts
Apache License 2.0
18 stars 28 forks source link

support aws session token in sms and kms clients #87

Closed jing-emma closed 6 months ago

jing-emma commented 6 months ago

This PR adds the support for aws session token in sms and kms clients to address the issue #85

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

jing-emma commented 6 months ago

@joanlopez @codebien Thank you for reviewing and approving the PR. I saw the build pipeline succeeded. Does that mean the new version 0.11.1 was released? where do I find the released js files. I thought I could use https://jslib.k6.io/aws/0.11.1/ssm.js. But I got 404.

joanlopez commented 6 months ago

Does that mean the new version 0.11.1 was released? where do I find the released js files. I thought I could use https://jslib.k6.io/aws/0.11.1/ssm.js. But I got 404.

Ha! That's a very fair question, that we're just right now discussing and re-defining (see https://github.com/grafana/k6-jslib-aws/pull/89). The process of releasing a new version is described in the CONTRIBUTING guidelines, and requires some manual steps that end up with the addition of the new build into https://github.com/grafana/jslib.k6.io repository, and a deployment to make it available in jslib.k6.io. However, we haven't published a new release with your changes yet, and indeed we haven't do it for a few more changes already available in main.

I hope to get that discussion resolved, and hopefully sooner rather than later we'll publish a new release (either v0.11.1 or v0.12.0). But so far, I guess you should be able to directly point the raw files of the build, hosted in the repository (e.g. https://raw.githubusercontent.com/grafana/k6-jslib-aws/main/build/ssm.js), as per what's commented here.

Apologies for the inconveniences, hopefully sometime in the near future we'll automate this process. Thanks for your comprehension, and again thanks for your contribution!