grafana / k6-operator

An operator for running distributed k6 tests.
Apache License 2.0
541 stars 147 forks source link

Add ReadOnly option to volumeMount in Pods #415

Closed irumaru closed 2 days ago

irumaru commented 3 weeks ago

Added ReadOnly to the volumeMount option in Pods to support mounting of ReadOnlyMany(ROX) PVC. https://github.com/grafana/k6-operator/issues/279

The default is ReadOnly: false. The reason was to avoid destructive changes, considering the possibility that some users may already be writing to the volume in the init container.

Here are the results of a simple test. files.zip

Test Contents

result describe-log.txt and get-log.txt are the execution results. You can confirm that ReadOnly for k6-test-volume is true.

irumaru commented 3 days ago

@yorugac , Thanks for the review.

We have made the following two corrections.

Please review.

yorugac commented 2 days ago

For info, failing CI for Helm on PRs is a known current issue: #419