grafana / k6-operator

An operator for running distributed k6 tests.
Apache License 2.0
576 stars 157 forks source link

Make `spec.paused` and `spec.quiet` a boolean in an upcoming version of the CRD #455

Open LCaparelli opened 3 weeks ago

LCaparelli commented 3 weeks ago

Feature Description

Unless there are plans to support other values and make it sort of an enum (which is also a breaking change), it probably makes more sense for spec.paused to be a bool. AFAICT from the code, we only use it as such anyway.

The current implementation leads to some awkwardness when using it, for example:

Suggested Solution (optional)

No response

Already existing or connected issues / PRs (optional)

No response

yorugac commented 2 weeks ago

Thanks for the issue, @LCaparelli! Such a change makes sense, AFAIS 👍

Btw, if we're going to break things here, we should also change spec.quiet type as well.