search

grafana / k6-operator

An operator for running distributed k6 tests.
Apache License 2.0
593 stars 166 forks source link

Fixing values.yaml docs for schema generation, corrected values.schema.json #474

Closed julian-perge closed 3 weeks ago

julian-perge commented 1 month ago

With 3.9.0, the values.schema.json is created incorrectly from the values.yaml, therefore not allowing any extra env values from manager.env to be placed in there since it's requiring an object, but env is supposed to be an array of objects.

Should fix https://github.com/grafana/k6-operator/issues/471

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

yorugac commented 1 month ago

Hi @julian-perge, thanks for the PR. According to the https://github.com/grafana/k6-operator/issues/471, there is probably a whole list of values that should be changed in the schema, if not all of them. If you'd like to work on that issue, https://github.com/grafana/k6-operator/issues/471, you're welcome to, but the schema overall should be fixed, not just a part of it. Also, just in case, signing CLA is mandatory for this repo :slightly_smiling_face:

julian-perge commented 1 month ago

Hi @julian-perge, thanks for the PR. According to the #471, there is probably a whole list of values that should be changed in the schema, if not all of them. If you'd like to work on that issue, #471, you're welcome to, but the schema overall should be fixed, not just a part of it. Also, just in case, signing CLA is mandatory for this repo 🙂

Thanks for the issue link, and I signed the CLA, but had my signing keys messed up. Should be fixed now.

Will probably work on improving the schema throughout the rest of the week when in down time.

julian-perge commented 1 month ago

@yorugac Updated PR to include the rest of the schema fixes.