grafana / k6-template-typescript

Template to use TypeScript with k6
Apache License 2.0
280 stars 66 forks source link

Fix webpack externals regex #6

Closed hinatades closed 3 years ago

hinatades commented 3 years ago

What does this PR do?

I have modified the regular expression for webpack externals. Currently, this regex is for k6 and k6/http, and it is better to have the condition that the name starts with k6.

Why is it important?

For example, if you start this template with the name prefix-k6/, without this condition, all modules will not be bundled.

simskij commented 3 years ago

Great catch! Thank you for your contribution! 🙏🏼