grafana / k6

A modern load testing tool, using Go and JavaScript - https://k6.io
GNU Affero General Public License v3.0
26.06k stars 1.27k forks source link

Address jhump/protoreflect deprecations introduced by v1.17.0 #4035

Open oleiade opened 2 weeks ago

oleiade commented 2 weeks ago

As we bumped our github.com/jhump/protoreflect/desc dependency to v0.17.0 we decided to postpone addressing the deprecations this specific version introduced.

Specifically:

As a result we have a couple of //nolint:staticcheck comments ignoring those deprecations explicitly. Those can be found in the following files:

Definition of done

We have replaced the deprecated packages import with their more modern counterparts, and the nolint statements have been removed.

7h3-3mp7y-m4n commented 3 days ago

hey can i pick this issue ?,Thanks!

mstoykov commented 3 days ago

This seems to be very specific to protoreflect, so it might not be as easy as it seems at first. @oleiade did have trouble finding out what was required which is why there is this issue.

But you are definitely welcome to work on it and open a PR

7h3-3mp7y-m4n commented 8 hours ago

I understand this might not be an easy issue to tackle, especially for beginners. However, I’d love to give it a try! I’m still learning, but I’m eager to work on fixing this.

I would really appreciate any guidance or assistance you can offer as I dive into this. I’ll reach out on Slack for more help :)