search

grafana / k8s-monitoring-helm

Apache License 2.0
208 stars 81 forks source link

Set default resource requests & limit in helm chart #753

Open nmehlei opened 1 month ago

nmehlei commented 1 month ago

Hello,

The helm chart is currently not setting resource requests & limits for the various deployments (e.g. alloy, kepler, opencost, prometheus-node-exporter, etc.). This can result in unbounded resource usage.

Should the chart set reasonable values here?

Alternatively, if for any reason this should not be set by default, then it would be useful to have an example on how to set these limits for each of the deployments within the chart values/parameters.

skl commented 1 month ago

At least for Alloy, the memory consumption is roughly proportional to the number of metric series (8-12 KiB RAM/series + whatever minimum is required by Alloy) - which in turn depends on the size of your cluster and the number of Alloy replicas in the StatefulSet.

OpenCost is likely to be affected by the size of the cluster, too.

The DaemonSets might be easier to predict, though.

I agree that it's a good idea to set a default and/or have an example 👍