grafana / kentik-app

3 stars 12 forks source link

wrong metric when looking at src/dest ips in query #43

Closed learhy closed 2 years ago

learhy commented 7 years ago

A plugin user has reported that the metric is incorrect when viewing src/dest IPs in a dashboard. It shows kbps which is obviously incorrect.

Here's a screenshot:

screen shot 2017-03-23 at 10 16 13 am

learhy commented 7 years ago

This is still considered a bug by Kentik. Please let us know the status of this request. Thank you.

jimfrey commented 7 years ago

This is still a bug. The units should change based on the type of metric being displayed.

jimfrey commented 6 years ago

This issue still exists. Please provide a status update and timeline for correction.

rozetko commented 6 years ago

It appears, that the value set by the dashboard template in Graph settings -> Axes -> Left Y -> Unit is the cause for this. Unfortunately, it cannot be changed by datasource

If this value is set to none manually - then any other metric will also have none as units.

This is how it looks when units is set to none: image

alexanderzobnin commented 5 years ago

@jimfrey The root cause of this issue is how Grafana set units for graph. Unit is a part of the panel's config, so in this case, we should update panels when user change variable Metric. This is possible, I think, but tricky a bit. Another problem is a side effect - when unit does change, dashoard model changes as well, so when you leave page, you'll see Unsaved changes dialog:

screen shot 2018-11-06 at 14 27 32

So, what do you think about this? Should we actually do this?