search

grafana / kubernetes-app

A set of dashboards and panels for kubernetes.
https://grafana.com/plugins/grafana-kubernetes-app
Apache License 2.0
401 stars 149 forks source link

Can't display individual nodes on Node dashboard if nodename contains a period #13

Open Timbus opened 6 years ago

Timbus commented 6 years ago

When selecting a node using the 'Kubernetes Node Info' panel, it appears that you use slugify to replace periods with underscores when a single node is selected.. And this propogates its way back to the $node variable in some way.

Unfortunately this breaks all of the default panels for us, because they're relying on $node to match nodename.

jtlisi commented 6 years ago

@Timbus Valid point, the slugify function should not remove periods from the nodename. That was a remnant from when this plugin was graphite based.

aleerizw-zz commented 6 years ago

@jtlisi I see that the commit has been merged are there plans to release a new version of the app?

andredantasrocha commented 6 years ago

It would be nice to have a new version released. We are facing the same issue

97turbotalon commented 6 years ago

We are also seeing the same issue. Is there any timeline for a new release?

buytler commented 6 years ago

Same here

watsutaz commented 6 years ago

Having the same exact issue.

petermein commented 6 years ago

Should this issue fixed after this commit? https://github.com/grafana/kubernetes-app/commit/ddf616e74c2146e72529316f4fb0348b787e38f4

I'm still experiencing the issue, in version 1.0.1 we have ip adresses as node names

rensreinders commented 6 years ago

Yeah, what he said

iMartyn commented 6 years ago

@jtlisi Can we get a 1.0.2 release please? There's a lot of people wanting fixes that are already merged.

lukasbernat commented 6 years ago

same. fix appreciated

Patafix commented 6 years ago

This repository is alive ?

jhinklew commented 6 years ago

Any progress on pushing a release out?

ghost commented 6 years ago

New release would be great

caiohasouza commented 6 years ago

+1

edclement commented 6 years ago

any update on this? it's been open a while. Thanks!

discsthnew commented 6 years ago

+1, and i also wait for new release for a while. but finally, i found out how to solve this problem, and now it's worked ! i wrote a blog to record the step i take, hope it helps you. here is my blog address https://blog.csdn.net/mailjoin/article/details/81389700#t7

aleerizw-zz commented 6 years ago

Seems like this project is dead, Kube-prometheus (https://github.com/coreos/prometheus-operator/tree/master/contrib/kube-prometheus) is a better alternative.

callmeradical commented 6 years ago

FYI - If you don't want to wait for a new release of this you can just clone this repo to the plugins directory as a temporary workaround.