search

grafana / kubernetes-app

A set of dashboards and panels for kubernetes.
https://grafana.com/plugins/grafana-kubernetes-app
Apache License 2.0
401 stars 149 forks source link

Fix Node/Cluster dashboards for node-exporter v0.16.0 #51

Open emcfarlane opened 5 years ago

foxdalas commented 5 years ago

@afking Nice fix. Big thanks

Sanwel commented 5 years ago

Have some question, not all query have 'node=$node' as selector, and I need to change it manually to 'kubernetes_node=$node'. Is there any point to make pull request with such changes?

emcfarlane commented 5 years ago

@Sanwel which queries are you having issues with?

neufeldtech commented 5 years ago

Any word on the status of getting this merged into master? It would be great to see the node dashboard fixed up for the node-exporter 0.16.0

CiaranCurran commented 5 years ago

@afking thanks for the fix, however, I am still having same issue mentioned by @Sanwel

In the k8s cluster dashboard the cluster disk usage and cluster disk capacity panels the node=$node query does not work as the nodes are referenced by 'kuberenetes_node' instead, which I have to set manually.

phedoreanu commented 5 years ago

@afking It would be great to have this merged!