Logql: Fix grammar for `String` - Githubissues

grafana / lezer-logql

LogQL lezer grammar

Apache License 2.0

3 stars 4 forks source link

Logql: Fix grammar for `String` #14

Closed ivanahuckova closed 2 years ago

ivanahuckova commented 2 years ago

Currently our grammar has incorrectly matched string in 3 cases:

If the string has single quotes '. This is not valid in LogQL.
If the string with quotes " didn't have closing " (more info: https://discuss.codemirror.net/t/trying-to-understand-lezer-grammar-for-string/2264)
If the string with back-tick ` didn't have closing ` (more info: https://discuss.codemirror.net/t/trying-to-understand-lezer-grammar-for-string/2264)

We are fixing this in this PR and adding tests.