search

grafana / lezer-logql

LogQL lezer grammar
Apache License 2.0
3 stars 4 forks source link

Fix npm publish workflow #35

Closed gwdawson closed 1 year ago

gwdawson commented 1 year ago

due to an oversight on my behalf, (https://github.com/grafana/lezer-logql/pull/34) didn't actually fix the issue.

as you can see from the demo, without the second half of the script, if husky doesn't exist it still throws an error making the workflow fail. however, with the second half, if husky doesn't exist the command just runs echo and doesn't error

github is now throwing errors whilst trying to upload the demo (linked in slack thread):

https://raintank-corp.slack.com/archives/C03PMJLVC67/p1689594553023209?thread_ts=1689588697.351199&cid=C03PMJLVC67

matyax commented 1 year ago 
➜  lezer-logql git:(main) test -d node_modules/husky && husky install || echo 'husky not installed... ignoring script'
zsh: command not found: husky
husky not installed... ignoring script

I'll recommend something shortly.

matyax commented 1 year ago

There's another thing that I don't like, which is that we use yarn to build the library, when we don't have a yarn.lock file, we use npm in this repo.

matyax commented 1 year ago

Btw, github actions can be tested with https://github.com/nektos/act