Logfmt: add support for new structure and new features (flags, arguments) - Githubissues

grafana / lezer-logql

LogQL lezer grammar

Apache License 2.0

3 stars 4 forks source link

Logfmt: add support for new structure and new features (flags, arguments) #52

Closed matyax closed 1 year ago

matyax commented 1 year ago

This PR does a small refactor to Logfmt related grammar to sync it with https://github.com/grafana/loki/blob/main/pkg/logql/syntax/expr.y, and to support new Logfmt features:

Flags: --strict --keep-empty
Arguments: label1, label2, label4="label3"

With these changes, new types of nodes have been introduced:

LogfmtParser
LogfmtExpressionParser (formerly included as a LabelParser)
LogfmtParserFlags
LabelExtractionExpressionList (former JsonExpressionList)
LabelExtractionExpression (former JsonExpression)

New trees:

simple tree

full tree

Part of https://github.com/grafana/grafana/issues/71121