search

grafana / lezer-logql

LogQL lezer grammar
Apache License 2.0
3 stars 4 forks source link

Logfmt: add support for new structure and new features (flags, arguments) #55

Closed svennergr closed 1 year ago

svennergr commented 1 year ago

Reverts grafana/lezer-logql#54

Adds this back. We shouldn't merge yet because we should figure out if this shouldn't be a major version increase?

matyax commented 1 year ago

Good point. I thought about this and I would lean into a major version if I was asked, due to the amount of breaking changes. BUT. We're the only users AFAIK, so I'm also not sure if it's worth overthinking it.

matyax commented 1 year ago

MAJOR version when you make incompatible API changes MINOR version when you add functionality in a backward compatible manner PATCH version when you make backward compatible bug fixes

Definitely should have been a major version increase.

matyax commented 1 year ago

Ready to revert the revert.

svennergr commented 1 year ago

Even though our current CHANGELOG.md is not great, do you mind adding a new entry there?

matyax commented 1 year ago

Updated, let me know what you think @svennergr

svennergr commented 1 year ago

Updated, let me know what you think @svennergr

That's great - thank you!