Allow MinIO storage class to be specified

micheljung commented 7 months ago

Is your feature request related to a problem? Please describe.

When trying to use Loki with MinIO, the documentation says to set:

minio:
  enabled: true

However, this only works if there is a default storage class in the cluster. If there isn't, the storageClass for MinIO is unset, preventing the MinIO PVC from being bound. The Loki Helm chart does not allow configuring it (like it does for singleBinary, backend, read, write).

Describe the solution you'd like

Make it possible to configure the MinIO storage class:

minio:
  persistence:
    storageClass: ""

Describe alternatives you've considered

Alternatively, MinIO can be set up without the Loki Helm Chart. Setting a default storage class works, too, but this may be undesired.

Additional context

I assume this is the MinIO property that needs to be set:

https://github.com/minio/minio/blob/152023e83715bf36a0cb7c9a9ad15af58884364e/helm/minio/values.yaml#L159

aaronriedel commented 7 months ago

You can specify it like this:

minio:
  enabled: true
  persistence:
    storageClass: longhorn-local

It should be added to the default values documentation in my opinion. It currently just works because minio is a subchart. That means you can specify all the values from the "real" minio chart that you linked.

micheljung commented 7 months ago

Thank you, I thought I tried this without success. I'll try again and let you know.

sepulworld commented 2 weeks ago

You can specify it like this:
minio:
  enabled: true
  persistence:
    storageClass: longhorn-local
It should be added to the default values documentation in my opinion. It currently just works because minio is a subchart. That means you can specify all the values from the "real" minio chart that you linked.

This didn't work for me.

grafana / loki

Allow MinIO storage class to be specified #11772